Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LGLanguageGenerator tests to address timeout failures #2076

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Refactor LGLanguageGenerator tests to address timeout failures #2076

merged 3 commits into from
Apr 22, 2020

Conversation

stevengum
Copy link
Member

Description

Split up monolithic tests into individual test cases in LGLanguageGenerator which were causing non-deterministic CI failures.

@coveralls
Copy link

coveralls commented Apr 21, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 122644

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 77.251%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 2 80.65%
libraries/botframework-streaming/src/webSocket/webSocketServer.ts 7 66.67%
Totals Coverage Status
Change from base Build 122625: -0.08%
Covered Lines: 11852
Relevant Lines: 14615
💛 - Coveralls

@stevengum stevengum merged commit cf7a3c2 into master Apr 22, 2020
@stevengum stevengum deleted the stgum/lg branch April 22, 2020 00:01
@stevengum stevengum mentioned this pull request Apr 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@chon219 chon219 Awaiting requested review from chon219

@cleemullins cleemullins Awaiting requested review from cleemullins

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevengum @coveralls @boydc2014