Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added GetConversationReference/ContinueConversation actions #3283

Merged
merged 12 commits into from
Feb 8, 2021
Merged

feat: Added GetConversationReference/ContinueConversation actions #3283

merged 12 commits into from
Feb 8, 2021

Conversation

chon219
Copy link
Member

@chon219 chon219 commented Feb 8, 2021

Fixes #3248

Description

Ported Added GetConversationReference/ContinueConversation actions from C# repo.

Specific Changes

  • Added action Microsoft.GetConversationReference
  • Added action Microsoft.ContinueConversation

Testing

Ported corresponding tests as well.

@chon219 chon219 added the Area: Adaptive The issue is related to Adaptive dialogs label Feb 8, 2021
@chon219 chon219 added this to the R12 milestone Feb 8, 2021
@chon219 chon219 requested review from chrimc62, tomlm and a team as code owners February 8, 2021 10:19
@coveralls
Copy link

coveralls commented Feb 8, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 549271639

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 84.882%
Totals Coverage Status
Change from base Build 549270799: 0.06%
Covered Lines: 18556
Relevant Lines: 20846
💛 - Coveralls

@stevengum stevengum mentioned this pull request Feb 8, 2021
Closed
@stevengum stevengum dismissed joshgummersall’s stale review February 8, 2021 21:13

Requested changes performed by @stevengum

@stevengum stevengum merged commit 729a577 into main Feb 8, 2021
@stevengum stevengum deleted the zim/conversation-actions branch February 8, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@joshgummersall joshgummersall joshgummersall left review comments

@chrimc62 chrimc62 Awaiting requested review from chrimc62

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
Area: Adaptive The issue is related to Adaptive dialogs
Projects
None yet
Milestone
R12
Development

Successfully merging this pull request may close these issues.

port: Added GetConversationReference/ContinueConversation actions (#4974)
4 participants
@chon219 @coveralls @joshgummersall @stevengum