Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bf luis:test command failures for corner cases of prebuilt entities #1148

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

feich-ms
Copy link
Contributor

Fix #1121. In some corner cases, the predicted entities will not return a standard format, e.g. the prebuilt ordinalV2 entity will return an object value like {offset: 1, relative: current} rather than string or number value, in such case, the entity parsing logic will throw exception caused by non validation. The fix is simple, just add the iterable validation for sub entities value. Test case is also adjusted to test this case.

@feich-ms feich-ms merged commit 5c86839 into main Mar 17, 2021
@feich-ms feich-ms deleted the feich/fix_luis_test branch March 17, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bf luis:test command fails for some files
2 participants