Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bf cli build spec #864

Merged
merged 5 commits into from
Jul 6, 2020
Merged

Add bf cli build spec #864

merged 5 commits into from
Jul 6, 2020

Conversation

munozemilio
Copy link
Member

@munozemilio munozemilio commented Jun 19, 2020 •
edited
Loading

Fixes #861

@munozemilio munozemilio mentioned this pull request Jun 19, 2020
Closed
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@87e42ae). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #864   +/-   ##
=========================================
  Coverage          ?   58.15%           
=========================================
  Files             ?      213           
  Lines             ?    15465           
  Branches          ?     2079           
=========================================
  Hits              ?     8993           
  Misses            ?     5910           
  Partials          ?      562

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e42ae...e9a4d1a. Read the comment docs.

scheyal
scheyal approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@scheyal scheyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@munozemilio munozemilio merged commit 534ff34 into master Jul 6, 2020
@munozemilio munozemilio deleted the munozemilio-build-spec branch July 6, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheyal scheyal scheyal approved these changes

@vishwacsena vishwacsena Awaiting requested review from vishwacsena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish preview builds to NPM
3 participants
@munozemilio @codecov-commenter @scheyal