Skip to content
This repository has been archived by the owner on Jun 30, 2022. It is now read-only.

Feich/update to do patterns in dispatch lu #364

Merged
merged 4 commits into from
Nov 30, 2018

Conversation

feich-ms
Copy link
Contributor

Update ToDo patterns in dispatch.lu

Description

Last time, I updated the luis model in skill project and forgot to update the patterns in VA manually. This PR is to update ToDo patterns in dispatch.lu

Related Issue

#51

If you have updated responses or .lu files:

  • All languages have been updated
  • You have tested deployment with your new models

@feich-ms feich-ms mentioned this pull request Nov 28, 2018
6 tasks
@feich-ms feich-ms added this to the Titanium milestone Nov 28, 2018
@lauren-mills
Copy link
Contributor

It looks like you only have two of the patterns for todo in the dispatch.lu file now... Seems like that would cause the other patterns to not be routed to the ToDo skill by the dispatcher?

@feich-ms
Copy link
Contributor Author

@lauren-mills I can give more detailed explanations about the issues in current update_all_deployment_scripts.bat.

  1. The script will pull all the pattern utterances from sub-skill lu files such as todo.lu into dispatch.luis. But the entities in the patterns are not pulled into dispatch.luis. You can remove all the patterns in the dispatch.lu to generate the dispatch.luis. You will find all the patterns from sub-skills are there but entities are not, so the luis portal will not accept this model.
  2. If we copy all the pattern utterances from sub-skill lu files to the dispatch.lu, run the script and then the generated dispatch.luis will have the pattern.any entities based on the copied pattern utterances in dispatch.lu. But all the pattern utterances will have two instances in the dispatch.luis file, one is pulled from sub-skill and another one comes from the copied utterances in the dispatch.lu. This will cause the duplicated patterns in luis model file so the luis portal will not accept it either.
  3. My solution here is to move two patterns with the pattern.any entities from sub-skill lu file to the dispatch.lu so that the generated dispatch.luis will have not only the patterns from sub-skills but also the needed entities with no duplicated patterns.

Please let me know if you have any questions.

@lauren-mills
Copy link
Contributor

lauren-mills commented Nov 29, 2018 via email

@feich-ms
Copy link
Contributor Author

feich-ms commented Nov 29, 2018 via email

@lauren-mills
Copy link
Contributor

lauren-mills commented Nov 29, 2018 via email

@feich-ms
Copy link
Contributor Author

feich-ms commented Nov 29, 2018 via email

@feich-ms
Copy link
Contributor Author

@lauren-mills updated the ludown to 1.0.36 version and the ludown works now. I added all the patterns in todo.lu to the dispatch.lu. Please review again.

@feich-ms feich-ms merged commit 9447fa8 into master Nov 30, 2018
@feich-ms feich-ms deleted the feich/UpdateToDoPatternsInDispatchLU branch November 30, 2018 00:46
lauren-mills pushed a commit that referenced this pull request Apr 18, 2019
* update todo luis model

* update patterns in dispatch.lu for todo

* update the dispatch.lu  file for todo based on ludown version 1.0.36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants