-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support launch by using named pipe #162
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76a89ef
to
2424dc0
Compare
init named pipe test build Server named pipe connection update named pipe stream solution finish forward message finish merge and named pipe fix - Handle older versions of Gradle (microsoft#149) Co-authored-by: Arthur McGibbon <arthur.mcgibbon@h3im.com> fix - Add JDK 22 compatibility support (microsoft#152) Signed-off-by: Sheng Chen <sheche@microsoft.com> fix - Return the root cause of the message (microsoft#156) feat - Add support for running tests (microsoft#144) Co-authored-by: Arthur McGibbon <arthur.mcgibbon@h3im.com> Co-authored-by: Sheng Chen <sheche@microsoft.com> add Launcher by namedPipe with backwards compatible
2424dc0
to
2ceb4de
Compare
jdneo
reviewed
Jul 2, 2024
server/src/main/java/com/microsoft/java/bs/core/internal/utils/ServerNamedPipeStream.java
Outdated
Show resolved
Hide resolved
jdneo
reviewed
Jul 2, 2024
jdneo
reviewed
Jul 22, 2024
server/src/main/java/com/microsoft/java/bs/core/internal/utils/NamedPipeStream.java
Outdated
Show resolved
Hide resolved
Could you please also add description for launching with named pipe in the section Launch the Build Server for Gradle of readme? |
jdneo
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support microsoft/vscode-gradle#1512