Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support launch by using named pipe #162

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

Jiaaming
Copy link
Contributor

@Jiaaming Jiaaming commented Jul 1, 2024

init named pipe

test build
Server named pipe connection

update named pipe stream solution

finish forward message

finish merge and named pipe

fix - Handle older versions of Gradle (microsoft#149)

Co-authored-by: Arthur McGibbon <arthur.mcgibbon@h3im.com>

fix - Add JDK 22 compatibility support (microsoft#152)

Signed-off-by: Sheng Chen <sheche@microsoft.com>

fix - Return the root cause of the message (microsoft#156)

feat - Add support for running tests (microsoft#144)

Co-authored-by: Arthur McGibbon <arthur.mcgibbon@h3im.com>
Co-authored-by: Sheng Chen <sheche@microsoft.com>

add Launcher by namedPipe  with backwards compatible
@Jiaaming Jiaaming marked this pull request as ready for review July 1, 2024 12:18
@jdneo jdneo added this to the 0.4.0 milestone Jul 22, 2024
@jdneo jdneo added the enhancement New feature or request label Jul 22, 2024
@jdneo
Copy link
Member

jdneo commented Jul 22, 2024

Could you please also add description for launching with named pipe in the section Launch the Build Server for Gradle of readme?

Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo jdneo merged commit e653195 into microsoft:develop Jul 22, 2024
4 checks passed
@Jiaaming Jiaaming deleted the merge-with-named-pipe branch July 26, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants