-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always-on-Top mode implemented #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderl
reviewed
Jul 11, 2019
sanderl
reviewed
Jul 11, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
joshkoon
reviewed
Jul 12, 2019
grochocki
previously approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving UX
joshkoon
reviewed
Jul 26, 2019
joshkoon
reviewed
Jul 26, 2019
grochocki
previously approved these changes
Jul 30, 2019
rudyhuyn
reviewed
Jul 30, 2019
joseartrivera
previously approved these changes
Jul 30, 2019
joseartrivera
previously approved these changes
Jul 30, 2019
…into always-on-top
liangchen07
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve from the PM perspective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the 2nd most user requested new feature: the ability for users to pin Calculator on top of other windows.
Description of the changes:
Button
has been added toTitleBar
and styled identical to the otherTitleBar
buttons. This button only appears in Standard calculator mode. Clicking on this button callsViewModePreferences
API to switch the window intoCompactOverlay
mode (and back, when exiting from Always-on-Top mode).ViewModel
is updated accordingly when the button is pressed. These updates propagate dependency properties and observable variables back to the UI to show/hide and enable/disable certain UI elements (eg. buttons) and keyboard shortcuts.LocalSettings
whenever the user resizes the screen in Always-on-Top mode. This is used for restoring the last used screen size when the user enters Always-on-Top mode.AdaptiveTriggers
andSizedChanged
event handlers are used to implement a responsive UI: certain buttons are hidden when the screen shrinks and the font sizes vary based on the screen size as well.ItemsControl
and aTextBlock
to render the desired mathematical result/expression. This scrollable expression shows the full mathematical expression when edited. When the user presses the "=" button, it shows the final computed result.How changes were validated:
Fixes #78