July-August 2021 Fixes #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Re-implements the CALT issue wherein LIG GSUB wouldn't work (this was lost during the fix. 2) Changes the STAT table generation library from statmake to gftools.stat, and all other necessary fixes.
Apparently this didn't get pushed up.
Adding Hebrew dflt language tag to ensure proper positioning.
At some point I added this line (or failed to remove it?), which actually causes issues in Jetbrains' capability to recognize the font on Windows devices. Changing the family name to "Cascadia Code Regular" resolves this issue.
removing "Medium" weight.
|
I cannot believe it's been since July. Okay. Is this ready to go, and does it fix more than just 500? Is there anything else we should get in before minting a 2108 copy of the font? I ask only because we're at a terminal revision point and I forgot that this had been open for all of human history |
|
Eh heh. It has been a crazy month. I think that's pretty much it for this PR. I've got some more fixes to submit at some point, but haven't had a chance to get them finalized, so those can wait. |
|
Oh, just remembered one it fixes too that I snuck in related to the Hebrew language tag. Added. |
|
Thanks 😄 I'll merge and build this as 2108.26, and we can come back with another entry once we get that stuff ironed out that we chatted about 😏 |
DHowett
approved these changes
Aug 26, 2021
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Aug 26, 2021
This update fixes some minor ligature issues, font selection issues and a problem with the Hebrew letter Vav when combined with Holam. See microsoft/cascadia-code#538 for more details.
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Aug 26, 2021
This update fixes some minor ligature issues, font selection issues and a problem with the Hebrew letter Vav when combined with Holam. See microsoft/cascadia-code#538 for more details. (cherry picked from commit de379cd)
DHowett
added a commit
to microsoft/terminal
that referenced
this pull request
Aug 26, 2021
This update fixes some minor ligature issues, font selection issues and a problem with the Hebrew letter Vav when combined with Holam. See microsoft/cascadia-code#538 for more details. (cherry picked from commit de379cd)
emaballarin
added a commit
to emaballarin/cascadia-code
that referenced
this pull request
Aug 27, 2021
July-August 2021 Fixes (microsoft#538)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This includes two fixes:
Closes [Question] How can I use only light and light italic by default in vscode? #500
Changes the build process to use gftools.stat instead of statmake. The issue was caused by an 'unused' italic axis in the fonts, which has been removed, but statmake gets unhappy without it there. So the process has been adjusted to a more amenable build library.
Closes U+05B9 HEBREW POINT HOLAM is positioned wrong on U+05D5 HEBREW LETTER VAV #552
Adds the Hebrew language tag to the Regular to ensure that Hebrew positioning works correctly.
Also:
Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the
ignoreactivate incorrectly. I thought this had already been PR'd but seems not.For example:
===]First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear.
Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.
In other news, I fixed my git repository.