Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

U+05B9 HEBREW POINT HOLAM is positioned wrong on U+05D5 HEBREW LETTER VAV #552

Closed
dscorbett opened this issue Jul 26, 2021 · 0 comments · Fixed by #538, emaballarin/cascadia-code#2 or Antyos/cascadios-code#1

Comments

@dscorbett
Copy link

Cascadia family version

2106.17

Cascadia family variant(s)

Cascadia Code (the version with ligatures), Cascadia Mono (the version without ligatures)

Font file format(s)

.ttf (variable), .ttf (static), .otf (static)

Platform

macOS 10.14.6

Other Software

No response

What happened?

<U+05D5 HEBREW LETTER VAV, U+05B9 HEBREW POINT HOLAM> is rendered wrong. The vowel sign should be directly above the letter.
וֹ
Compare its precomposed form, U+FB4B HEBREW LETTER VAV WITH HOLAM, which is rendered correctly.
וֹ
Also compare <U+05D5 HEBREW LETTER VAV, U+05BA HEBREW POINT HOLAM HASER FOR VAV>, which is also rendered correctly.
וֺ

@aaronbell aaronbell mentioned this issue Aug 25, 2021
2 tasks
DHowett pushed a commit that referenced this issue Aug 26, 2021
## Summary of the Pull Request

This includes two fixes:
- [x] Closes #500 
Changes the build process to use gftools.stat instead of statmake. The issue was caused by an 'unused' italic axis in the fonts, which has been removed, but statmake gets unhappy without it there. So the process has been adjusted to a more amenable build library. 

- [x] Closes #552
Adds the Hebrew language tag to the Regular to ensure that Hebrew positioning works correctly. 

Also:
Adjusts calt feature to ensure LIG substitutions properly function under rare conditions where the `ignore` activate incorrectly. I thought this had already been PR'd but seems not. 

For example:
`===]`
First = becomes "equal_equal.liga", and ignore would activate on second =, blocking LIG from being substituted. If the liga form appears, LIG should appear.

Turned back on the =>> =<<, etc. ligatures as there is a glyph for them now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant