Skip to content

Commit

Permalink
Changed default build platform to win-x64 even in Linux scripts (#606)
Browse files Browse the repository at this point in the history
### Motivation and Context
Building for Linux makes packages incompatible with our deployed
resources.

### Description
Build for win-x64 by default instead of of linux-x64.

Users can override if they want to build linux-x64 version.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
  • Loading branch information
glahaye authored Nov 13, 2023
1 parent 37df9d7 commit d3e3bfd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions scripts/deploy/package-memorypipeline.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ usage() {
echo "Arguments:"
echo " -c, --configuration CONFIGURATION Build configuration (default: Release)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net6.0)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: linux-x64)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: win-x64)"
echo " -o, --output OUTPUT_DIRECTORY Output directory (default: $SCRIPT_ROOT)"
echo " -v --version VERSION Version to set files to (default: 1.0.0)"
echo " -i --info INFO Additional info to put in version details"
Expand Down Expand Up @@ -69,7 +69,7 @@ done
# Set defaults
: "${CONFIGURATION:="Release"}"
: "${DOTNET:="net6.0"}"
: "${RUNTIME:="linux-x64"}"
: "${RUNTIME:="win-x64"}"
: "${VERSION:="1.0.0"}"
: "${INFO:=""}"
: "${OUTPUT_DIRECTORY:="$SCRIPT_ROOT"}"
Expand Down
4 changes: 2 additions & 2 deletions scripts/deploy/package-webapi.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ usage() {
echo "Arguments:"
echo " -c, --configuration CONFIGURATION Build configuration (default: Release)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net6.0)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: linux-x64)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: win-x64)"
echo " -o, --output OUTPUT_DIRECTORY Output directory (default: $SCRIPT_ROOT)"
echo " -v --version VERSION Version to set files to (default: 1.0.0)"
echo " -i --info INFO Additional info to put in version details"
Expand Down Expand Up @@ -76,7 +76,7 @@ echo "Building backend executables..."
# Set defaults
: "${CONFIGURATION:="Release"}"
: "${DOTNET:="net6.0"}"
: "${RUNTIME:="linux-x64"}"
: "${RUNTIME:="win-x64"}"
: "${VERSION:="0.0.0"}"
: "${INFO:=""}"
: "${OUTPUT_DIRECTORY:="$SCRIPT_ROOT"}"
Expand Down

0 comments on commit d3e3bfd

Please sign in to comment.