Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chat Copilot - chats won't load, blank screen due to unhandled exception #438

Closed
gitri-ms opened this issue Oct 2, 2023 · 0 comments · Fixed by #442
Closed

Chat Copilot - chats won't load, blank screen due to unhandled exception #438

gitri-ms opened this issue Oct 2, 2023 · 0 comments · Fixed by #442
Assignees
@gitri-ms
Labels
bug Something isn't working regression Issues related to regressions in functionality sk team issue

Comments

@gitri-ms
Copy link
Collaborator

gitri-ms commented Oct 2, 2023 •
edited
Loading

Describe the bug
When I try to load Chat Copilot (pre-existing deployment with new/recent updates), It says "Loading Chats" and then I get a blank screen. The following exception is thrown:

react-dom.production.min.js:189  TypeError: Cannot read properties of undefined (reading 'indexOf')
    at lq (PlanUtils.ts:6:41)
    at _q (PlanViewer.tsx:83:30)
    at Ca (react-dom.production.min.js:167:137)
    at Cc (react-dom.production.min.js:290:337)
    at ku (react-dom.production.min.js:280:389)
    at yu (react-dom.production.min.js:280:320)
    at mu (react-dom.production.min.js:280:180)
    at au (react-dom.production.min.js:271:88)
    at iu (react-dom.production.min.js:268:429)
    at x (scheduler.production.min.js:13:203)

This appears to be regression / breaking change from #409. I have at least one plan in my chat history that doesn't have the userIntent or originalUserInput fields. I have a 100% repro of this issue and can provide more details offline.
@gitri-ms gitri-ms added bug Something isn't working sk team issue regression Issues related to regressions in functionality labels Oct 2, 2023
@gitri-ms gitri-ms self-assigned this Oct 2, 2023
@gitri-ms gitri-ms mentioned this issue Oct 2, 2023
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 2, 2023
@gitri-ms
Fix null dereference from empty intent/input (#442)
19868f0 
### Motivation and Context
Fixes #438 

### Description
Old plans do not have the `userIntent` or `originalUserInput` fields, so
use the plan description as a fallback to populate the goal.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitri-ms gitri-ms

Labels
bug Something isn't working regression Issues related to regressions in functionality sk team issue
Projects
No open projects
Apps & Services Semantic Kernel
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix null dereference from empty intent/input gitri-ms/chat-copilot
1 participant
@gitri-ms