Fix null dereference from empty intent/input #442

gitri-ms · 2023-10-02T18:49:31Z

Fixes #438

Old plans do not have the userIntent or originalUserInput fields, so use the plan description as a fallback to populate the goal.

The code builds clean without any errors or warnings
The PR follows the Contribution Guidelines and the pre-submission formatting script raises no violations
All unit tests pass, and I have added new tests where possible
I didn't break anyone 😄

Fix null dereference from empty intent/input

3283a25

gitri-ms requested a review from teresaqhoang October 2, 2023 18:49

gitri-ms self-assigned this Oct 2, 2023

github-actions bot added the webapp Pull requests that update Typescript code label Oct 2, 2023

Add parentheses

8933b6b

teresaqhoang previously approved these changes Oct 2, 2023

View reviewed changes

alliscode previously approved these changes Oct 2, 2023

View reviewed changes

Fix linter error

6ef1340

gitri-ms dismissed stale reviews from alliscode and teresaqhoang via 6ef1340 October 2, 2023 20:45

Fix style

cbc4e32

gitri-ms requested review from alliscode and teresaqhoang October 2, 2023 21:49

teresaqhoang approved these changes Oct 2, 2023

View reviewed changes

gitri-ms added this pull request to the merge queue Oct 2, 2023

Merged via the queue into microsoft:main with commit 19868f0 Oct 2, 2023
6 checks passed

gitri-ms deleted the plan-goal-fix branch October 2, 2023 22:45

gitri-ms added the PR: regression fix Used to track PRs that fix a regression in the main branch label Oct 3, 2023

Provide feedback