Fix packaging bash scripts #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehoward
added
PR: regression fix
glahaye
reviewed
Sep 28, 2023
glahaye
approved these changes
Sep 28, 2023
dehoward
approved these changes
Sep 28, 2023
|
was this actually tested on Linux/WSL? |
gormaar
pushed a commit
to equinor/chat-copilot
that referenced
this pull request
Nov 29, 2023
### Motivation and Context
This PR adds support to acquire an access token using MSAL. It passes
this under a new header when making SK server requests, and the user ID
token is also added under the 'Authorization' header.
### Description
This implementation follows the 'incremental consent' concept, where the
User will only be prompted for 'openid', 'offline_access', 'profile',
and 'User.Read' consent on login. Further permissions will require
additional consent, in which the user will be prompted when a request
for the token is made.
If consent is granted and user is authorized, the access token will be
passed to the server under this header:
`sk-copilot-connector-access-token`. The `Authorization` header is
reserved for the SK Access token.
To invoke skills with tokens, do the following (see comments in useChat
for example):
1. `import { useConnectors } from '{path}/connectors/useConnectors';`
2. In component: `const connectors = useConnectors();`
3. Invoke Skill with scopes required for connector as an array, i.e.
`const scopes = ['User.Read']`
To use Graph token specifically, comment out the scopes you need under
`msGraphScopes` in `Constants.ts`, then call the i.e.,
`invokeSkillWithGraphToken` function. Be default, the ones already
uncommented map to Graph APIs used in existing connectors.
`var result = await connectors.invokeSkillWithGraphToken(ask,
'ChatSkill', 'Chat');`
To use ADO token specifically, comment out the scopes you need under
`adoScopes` in `Constants.ts`, then call the `invokeSkillWithAdoToken`
function.
i.e., `var result = await connectors.invokeSkillWithAdoToken(ask,
'ChatSkill', 'Chat');`
+ Error Handling
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> Running the packaging bash scripts in the repo will result in the following error:  This is caused by un-escaped characters in the build options. ### Description Fix the issue by escaping the characters in the build options. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Running the packaging bash scripts in the repo will result in the following error:
This is caused by un-escaped characters in the build options.
Description
Fix the issue by escaping the characters in the build options.
Contribution Checklist