Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing conversation filtering #642

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

teresaqhoang
Copy link
Contributor

@teresaqhoang teresaqhoang commented Nov 21, 2023

Motivation and Context

This PR removes part of the isFiltering conversations view state, including an unnecessary filteredConversations field, since @TaoChenOSU's filters and sorts the conversations into the expected Latest and Older conversations lists.

Also, fixes a bug so the filter is applied to the client view name, rather than the actual saved name on the object since this is what our end user sees and would expect the search text to check against.

Contribution Checklist

@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Nov 21, 2023
@teresaqhoang teresaqhoang marked this pull request as ready for review November 21, 2023 01:53
@teresaqhoang teresaqhoang linked an issue Nov 21, 2023 that may be closed by this pull request
@teresaqhoang
Copy link
Contributor Author

@threegitty350 take a look at this and see if it helps with the issue you're seeing

@momuno
Copy link
Member

momuno commented Nov 21, 2023

I tested this locally and filtering works now.

@momuno momuno added this pull request to the merge queue Nov 21, 2023
Merged via the queue into microsoft:main with commit 75a06d0 Nov 21, 2023
6 checks passed
@teresaqhoang teresaqhoang deleted the tehoang/chat-filtering-fix branch November 21, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
webapp Pull requests that update Typescript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search filter does not work "Filter by name"
2 participants