Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings from yarn regarding node-uuid #419

Closed
fungilation opened this issue Mar 16, 2017 · 9 comments
Closed

Warnings from yarn regarding node-uuid #419

fungilation opened this issue Mar 16, 2017 · 9 comments
Labels
enhancement

Comments

@fungilation
Copy link

fungilation commented Mar 16, 2017 •
edited

On every yarn upgrade:

warning react-native-code-push > code-push > node-uuid@1.4.7: use uuid module instead
warning react-native-code-push > xcode > node-uuid@1.4.7: use uuid module instead

Perhaps the warning can be fixed as suggested, if it's "correct"?

Using code-push 1.8.0-beta
@fungilation fungilation changed the title Warnings from yarn (on every upgrade) Warnings from yarn regarding node-uuid Mar 16, 2017
@max-mironov
Copy link
Contributor

Looks like the package node-uuid package on npm has been deprecated but the repo hasn't been because its now serving up the source code for uuid. More details here uuidjs/uuid#155

@Silhouettes - I've searched through code-push project and it seems that we are not using node-uuid module any more at this time. What do you think, is it ok if we remove this dependency completely from our code-push package.json?

@richardhuaaa
Copy link
Contributor

@max-mironov great catch! yes, please remove this dependency completely.

@richardhuaaa richardhuaaa mentioned this issue Mar 23, 2017
Merged
@richardhuaaa
Copy link
Contributor

Oh, @max-mironov - the xcode dependency also uses node-uuid, so the warning will still show up even after my PR is merged. You might need to look at that separately.

@max-mironov
Copy link
Contributor

max-mironov commented Mar 23, 2017 •
edited

@Silhouettes - I've looked closer at this and it turns out that nothing we can do with this warning.
As it is stated here expo/create-react-native-app#86 this warning appears due to our code-push-react-native (as well as react-native) have dependency upon xcode package which is in its turn dependent upon node-uuid package.
So I believe we should wait until xcode package will update their dependencies.

@richardhuaaa
Copy link
Contributor

@max-mironov - gotcha! Thanks for looking into that. So I guess we've done all we can on our end.

@fungilation fungilation mentioned this issue Mar 23, 2017
Merged
@max-mironov
Copy link
Contributor

@fungilation thank you for referencing the issue in node-xcode repository. Currently we'll left this item open and wait for new release of xcode to bump dependency accordingly.

@fungilation
Copy link
Author

it's version bumped to include the move to uuid: alunny/node-xcode#117 (comment)

max-mironov pushed a commit to max-mironov/react-native-code-push that referenced this issue Apr 3, 2017
Bump xcode dependency
30355d0 
Should fix Warnings from yarn regarding node-uuid microsoft#419 (microsoft/code-push#419) issue
@max-mironov max-mironov mentioned this issue Apr 3, 2017
Merged
@max-mironov
Copy link
Contributor

Hey @fungilation, thanks for heads up!
We have updated xcode dependency on our side in this PR.

However currently we will still see this warnings for 2 reasons:

  1. react-native package depends upon old xcode package, we cannot force them to update it immediately
  2. our react-native-code-push package have a dependency for code-push 1.8.0-beta which is outdated. Unfortunately we should wait for new code-push release which will include this PR and after that we can update this dependency also.

We'll try to update this as soon as possible.

max-mironov pushed a commit to microsoft/react-native-code-push that referenced this issue Apr 4, 2017
Bump xcode dep (#776)
3d35287 
* Modified Issue_Template to be more descriptive

* Some minor changes to Description field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, #723, #717

* Minor additional tweak for readme

* Bump xcode dependency

Should fix Warnings from yarn regarding node-uuid #419 (microsoft/code-push#419) issue
max-mironov pushed a commit to max-mironov/react-native-code-push that referenced this issue Apr 14, 2017
Bump code-push dependency
8ae8fde 
See microsoft/code-push#419 for details
@max-mironov max-mironov mentioned this issue Apr 14, 2017
Merged
max-mironov pushed a commit to microsoft/react-native-code-push that referenced this issue Apr 14, 2017
Bump code-push dependency (#796)
57a1e43 
See microsoft/code-push#419 for details
@max-mironov
Copy link
Contributor

Closing this as fix was released with React Native Code Push 2.0.3.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@richardhuaaa @fungilation @sergey-akhalkov @max-mironov