Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-push release-react myapp android it shows an update on iOS and it breaks it (flags it as broken on iOS) #723

Closed
octohedron opened this issue Feb 27, 2017 · 1 comment

Comments

@octohedron
Copy link

octohedron commented Feb 27, 2017

Issuing code-push release-react myapp android shows an update on iOS and it breaks it (flags it as broken on iOS) so new app installs won't get the latest version because it's flagged as broken.

I guess this could be solved by having two different apps instead of one, for each platform, but the docs don't say that.

Same thing happens when doing code-push release-react myapp ios -b main.jsbundle, it shows an update available on Android, and then flags it as broken, so if you want to install the latest update it wont, it won't install any update unless you release another update for Android.

  • react-native-code-push version: 1.16.1-beta
  • react-native version: 0.41.2
  • iOS/Android/Windows version: latest
  • Does this reproduce on a debug build or release build? either
  • Does this reproduce on a simulator, or only on a physical device? both
  • Repro steps and/or stack trace: explained above

EDIT: Yes, looks like the docs are wrong, and you need two different apps. Please make that very clear in the docs because others are also experiencing this issue.

@richardhuaaa
Copy link
Contributor

@octohedron - Thanks for the issue, and apologies for the confusion! We've already tried to mention the need for an app for each platform in the docs wherever we could, but of course there still might be gaps. Could you be more specific about where we should add this clarification?

@max-mironov - When he replies, could you add that clarification there?

@max-mironov max-mironov self-assigned this Feb 28, 2017
max-mironov pushed a commit to max-mironov/react-native-code-push that referenced this issue Mar 3, 2017
…fferent platforms more clear

Due to multiple requests in discord chanel, microsoft#723, microsoft#717
max-mironov pushed a commit to max-mironov/code-push that referenced this issue Mar 3, 2017
max-mironov pushed a commit that referenced this issue Mar 7, 2017
* Modified Issue_Template to be more descriptive

* Some minor changes to Description field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, #723, #717

* Minor additional tweak for readme
max-mironov pushed a commit to microsoft/code-push that referenced this issue Mar 7, 2017
#406)

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* Minor tweak for readme
max-mironov pushed a commit to microsoft/code-push that referenced this issue Mar 10, 2017
* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* Add ability to specify build type for Cordova
Also fixes issue #392

* revert changes not related to this PR

* Minor tweak for readme

* Reordered param names for cordova-release command in Readme alphabetically
max-mironov pushed a commit to microsoft/cordova-plugin-code-push that referenced this issue Mar 15, 2017
* Modified Issue_Template to be more descriptive

* Some minor changes to decription field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* FIxed spelling for Readme
max-mironov pushed a commit to microsoft/cordova-plugin-code-push that referenced this issue Mar 23, 2017
* Modified Issue_Template to be more descriptive

* Some minor changes to decription field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* FIxed spelling for Readme

* Supress XCode warnings on build

See #218 for details
@panarasi panarasi added this to Waiting for User in React Native Board Apr 3, 2017
max-mironov pushed a commit that referenced this issue Apr 4, 2017
* Modified Issue_Template to be more descriptive

* Some minor changes to Description field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, #723, #717

* Minor additional tweak for readme

* Bump xcode dependency

Should fix Warnings from yarn regarding node-uuid #419 (microsoft/code-push#419) issue
max-mironov pushed a commit to microsoft/code-push that referenced this issue Jul 19, 2017
* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* Minor tweak for readme

* Add ability to use plain integer number for app version

See #377 for details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants