Update acquisition sdk to work with new service #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfleidi
approved these changes
Aug 14, 2019
|
Can we get a bump to the next major version since this will be a breaking change? When it comes time to publish, we should also make it a beta release until we have the new RN SDK and Cordova plugin updated. Otherwise, LGTM 👍 |
|
@cjonsmith , usually we bump version right away before release. I'm not sure if we really need to have beta release as we can update CodePush sdk and react-native/cordova plugins at the same time. |
alexandergoncharov-zz
deleted the
goncharov/update_acquisition-sdk_to_worj_with_new_service
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UpdateCheckRequest,UpdateCheckResponse,DeploymentStatusReport,DownloadReport.