Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow recording code span highlighting #5

Closed
lostintangent opened this issue Mar 8, 2020 · 2 comments
Closed

Allow recording code span highlighting #5

lostintangent opened this issue Mar 8, 2020 · 2 comments
Labels
area: recording enhancement New feature or request

Comments

@lostintangent
Copy link
Member

Currently, you can select a line of code and attach a comment to it. However, you may want to highlight a multi-line span of code and annotate that. We should explore how to introduce support for doing that.
@lostintangent lostintangent added enhancement New feature or request area: recording labels Mar 8, 2020
@ShaunWMusic
Copy link

yes! I agree this would be very useful as I use this feature in Github reviews quite often now.

@lostintangent
Copy link
Member Author

lostintangent commented Mar 15, 2020 •
edited
Loading

This has been checked into master and will be released this afternoon.

CT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: recording enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lostintangent @ShaunWMusic