Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Commit

Permalink
Fix Xcode warnings on building (#235)
Browse files Browse the repository at this point in the history
* Modified Issue_Template to be more descriptive

* Some minor changes to decription field

* Improved messages to make intention of creating different apps for different platforms more clear

Due to multiple requests in discord chanel, microsoft/react-native-code-push#723, microsoft/react-native-code-push#717

* FIxed spelling for Readme

* Supress XCode warnings on build

See #218 for details
  • Loading branch information
max-mironov committed Mar 23, 2017
1 parent cc80804 commit 055d9e6
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions src/ios/CodePushReportingManager.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#import "CodePushReportingManager.h"
#import "StatusReport.h"

#pragma GCC diagnostic ignored "-Wundeclared-selector"

@implementation CodePushReportingManager

int HasFailedReport = -1; // -1 = unset, 0 = false, 1 = true
Expand Down
2 changes: 1 addition & 1 deletion src/ios/InstallOptions.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ -(void)encodeWithCoder:(NSCoder*)encoder {

-(id)initWithCoder:(NSCoder*)decoder {
self.installMode = [decoder decodeIntegerForKey:InstallModeKey];
self.minimumBackgroundDuration = [decoder decodeIntegerForKey:MinimumBackgroundDurationKey];
self.minimumBackgroundDuration = (int)[decoder decodeIntegerForKey:MinimumBackgroundDurationKey];
return self;
}

Expand Down
2 changes: 1 addition & 1 deletion src/ios/UpdateHashUtils.m
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ + (NSString*)computeFinalHashFromManifestEntries:(NSMutableArray*)manifest
+ (NSString*)computeHashForData:(NSData*)inputData
{
uint8_t digest[CC_SHA256_DIGEST_LENGTH];
CC_SHA256(inputData.bytes, inputData.length, digest);
CC_SHA256(inputData.bytes, (CC_LONG)inputData.length, digest);
NSMutableString* inputHash = [NSMutableString stringWithCapacity:CC_SHA256_DIGEST_LENGTH * 2];
for (int i = 0; i < CC_SHA256_DIGEST_LENGTH; i++) {
[inputHash appendFormat:@"%02x", digest[i]];
Expand Down

0 comments on commit 055d9e6

Please sign in to comment.