-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors when building SampleCpp or packaging Nuget #94
Comments
We don't currently officially support the nuget build process. This is a good resource that explains how to create a nuget and how nuspec works : Linking issue is a recent regression from yesterday, you should be able to rollback to Friday's commit id. The fix for that issue is on code review in the list of open Pull Requests, to be merged tomorrow. |
In order to build the full set of binaries:
This will build SDK and copy all binaries into dist folder. After that please run the nuget packaging scripts, that are expecting the binaries in a certain location. You do not need to package the unrelated libraries (e.g. net40 SKU), only the ones you need for your product. If you are packaging a nuget for native Universal Windows app, then you will use Microsoft.Applications.Telemetry.Windows.native.dll and its flavors (x86,x64,arm,arm64), both (Release,Debug). We do not provide code signing as part of our build pipeline. In order to provide a nuget consumable within your organization you have to rely on your org code signing pipeline. If you are packaging a nuget for native Win32 Desktop app, then you will use the ClientTelemetry.dll and its flavors (x86,x64,arm64). Linking issue described in your scenario is a recent regression. You can cherry-pick the fix from here to try, or wait until it gets merged in the master #93 The rest is a documentation issue for a process that we do not currently maintain nor officially support at this point due to resourcing constraints. Not a bug. I would suggest to review where the dlls get published after the build is done. Then review some common guidelines on creating a nuget package geared towards consumption within your org. |
Thanks for the detailed info. I was able to build after reverting to last week's bits. We will work to generate a nuget package for our use-case. |
We'll work on doc updates and more user-friendly nuget scripts, but as a lower priority (ETA: October-November). We might be able to resurrect the nuget package build, if that activity gets staffed / resourced by SLT. If you feel like there is a need for one centralized team in Azure PIE to provide the nuget, please highlight that ask to @tvilliers |
I have just cloned the repo and have VS 2017.
When I first attempted to open the solution I was prompted to install VS tools, which I did.
Next time I was able to open the solution, but building the SampleCpp project resulted in a syntax error (attached).
When I commented that line out and rebuilt, I ended up linker errors (attached).
Since the win32-dll project actually built successfully, I decided to ignore those errors and attempt to generate a nuget package for the sdk.
Running build-nugets.cmd from /tools resulted in many errors for native and net40, with a success message for uap, though I suspect there are no files in the package. The errors seems to be due to a non-existent /dist folder and absence of any /lib or /include folder inside /tools/Nuget/native. (Attached)
I know I must be doing something fundamentally wrong, just not sure what it is.
LinkErrors.txt
PackageErrors.txt
SyntaxError.txt
The text was updated successfully, but these errors were encountered: