.dll flavor broken #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking on Windows win32-dll flavor. Unfortunately we do not have a linking test on Windows - test runners are statically linked. The issue wasn't impacting Office nor MIP, since both are statically linking our API. The fix is to add the proper export. Note that we ignore the warning for STL runtime, on std::map, std::string and std::shared_ptr, and are not exporting all the required template class specializations for these STL classes. No ABI compat promises here (we never had that promise) -- it all works only with maching STL runtime.
trevorlacey-msft
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes made to ILogConfiguration and addition of IModule were breaking on Windows win32-dll flavor. Unfortunately we do not have a linking test on Windows - test runners are statically linked.
It would be ideal to add a test runner that simply verifies the ClientTelemetry.dll , not just the core statically linked .lib The issue wasn't impacting Office nor MIP, since both are statically linking our API.
The fix is to add the proper export. Note that we ignore the warning for STL runtime -- on std::map, std::string and std::shared_ptr ... And are not exporting all the required template class specializations for these STL classes. No ABI compat promises here (we never had that promise), and it would only work well with maching STL runtime that has a compatible / identical template class specialization.