Fix #731: "externalTerminal" does not work on Linux

Do not wait for "runInTerminal" response when spawning the launcher.
microsoft · Jun 29, 2022 · 7676e29 · 7676e29
1 parent 627bc1d
commit 7676e29
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/debugpy/adapter/launchers.py b/src/debugpy/adapter/launchers.py
@@ -155,7 +155,9 @@ def on_launcher_connected(sock):
             if cwd is not None:
                 request_args["cwd"] = cwd
             try:
-                session.client.channel.request("runInTerminal", request_args)
+                # It is unspecified whether this request receives a response immediately, or only
+                # after the spawned command has completed running, so do not block waiting for it.
+                session.client.channel.send_request("runInTerminal", request_args)
             except messaging.MessageHandlingError as exc:
                 exc.propagate(start_request)