Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable overriding "pythonPath" in the launcher #463

Closed
int19h opened this issue Nov 5, 2020 · 3 comments
Closed

Enable overriding "pythonPath" in the launcher #463

int19h opened this issue Nov 5, 2020 · 3 comments
Assignees
@int19h
Labels
enhancement New feature or request

Comments

@int19h
Copy link
Collaborator

int19h commented Nov 5, 2020

Problem: microsoft/vscode-docker#2455 (comment)

To solve this, the launcher needs to provide some way to override "pythonPath" that comes from the client (via the adapter), such that the custom launcher script that the Docker extension registers can change it.
@int19h int19h added the enhancement New feature or request label Nov 5, 2020
@int19h int19h self-assigned this Nov 5, 2020
@bwateratmsft bwateratmsft mentioned this issue Nov 9, 2020
Closed
@int19h
Copy link
Collaborator Author

int19h commented Nov 9, 2020

As described here: microsoft/vscode-docker#2455 (comment)

@int19h int19h mentioned this issue Nov 9, 2020
Closed
int19h added a commit to int19h/debugpy that referenced this issue Nov 10, 2020
@int19h
Fix microsoft#463: Enable overriding "pythonPath" in the launcher
8641acd 
Add "debugLauncherPython" debug config property to customize Python interpreter used to spawn the launcher.
@dev-michael-schmidt
Copy link

I can confirm backing out to docker versions 1.6.0 and python (extension) version 2020.8.109390 will work around this regression.

@bwateratmsft
Copy link

bwateratmsft commented Nov 11, 2020 •
edited

I think reverting Docker shouldn't be necessary.

int19h added a commit to int19h/debugpy that referenced this issue Nov 11, 2020
@int19h
Fix microsoft#463: Enable overriding "pythonPath" in the launcher
be60eb3 
Add "debugLauncherPython" debug config property to customize Python interpreter used to spawn the launcher.
@int19h int19h closed this as completed in 7d2a7a2 Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@int19h int19h

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@int19h @dev-michael-schmidt @bwateratmsft and others