Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: use 1ES compliant GitHub runner #36

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

MIchaelMainer
Copy link
Member

@MIchaelMainer MIchaelMainer commented Nov 23, 2022

Closes #35

Let me know if you see any issues running the GitHub Actions especially if you find yourself waiting for a runner for too long.

@MIchaelMainer MIchaelMainer requested a review from a team as a code owner November 23, 2022 00:14
@MIchaelMainer MIchaelMainer marked this pull request as draft November 23, 2022 00:31
@MIchaelMainer MIchaelMainer marked this pull request as ready for review November 23, 2022 18:50
@MIchaelMainer MIchaelMainer merged commit 7118756 into main Nov 23, 2022
@MIchaelMainer MIchaelMainer deleted the task/set1ESpool branch November 23, 2022 19:09
@waldekmastykarz
Copy link
Collaborator

@gavinbarron have you noticed that the build https://github.com/microsoftgraph/msgraph-developer-proxy/actions/runs/3534878538/jobs/5932262509 failed? Is this related to the 1es runner or something else?

@gavinbarron
Copy link
Contributor

@waldekmastykarz it is. We'll need to monitor these actions as we use them and get solid with these new runners.
When they are hung it seems that cancelling and restarting the job is picking up the runner quickly

@MIchaelMainer
Copy link
Member Author

There is some brittleness in 1es runner system. If we encounter hung runners, cancel all actions that are using the 1es runners before resubmitting the job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 1ES hosted runner
3 participants