-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging and Telemetry should be combined #117
Comments
Suggestion:
Challenges that needs to be solved:
For example: public SetupFlowService(ILogger logger)
{
logger.Info("Hello world"); // [SetupFlow] Hello world
}
public DashboardService(ILogger logger)
{
logger.Info("Hello world"); // [Dashboard] Hello world
} |
I don't think we need DI for this. If I understand correctly the benefits are being able to mock it which I don't think we need for these, and some help with getting the instances where we need them, which can be solved with a singleton like it's currently done for the dashboard.
Why not keep them separate? The data needed for the two of them seems quite different. For logging we ultimately want a readable string, whereas for telemetry we want a identifier string plus an object with related data. |
Discussed offline, after we have a working PoC of a logger in the Related work: |
@florelis or @AmelBawa-msft can this issue be closed? |
I suggest keeping this issue open for now. Telemetry and logging will potentially remain separate, but I still need to look into making the logger available from the container instead of a |
Description of the new feature / enhancement
Having two
ILogger
s is ambiguous.Scenario when this would be used?
No response
Supporting information
No response
The text was updated successfully, but these errors were encountered: