Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor telemetry and add configuration events #310

Merged
merged 5 commits into from
May 1, 2023
Merged

Refactor telemetry and add configuration events #310

merged 5 commits into from
May 1, 2023

Conversation

florelis
Copy link
Member

Summary of the pull request

This PR does some refactoring of the telemetry code, hopefully improving it, and adds events for configuration.

References and relevant issues

https://task.ms/44339984
Related to #117, but in a totally different direction than it suggested

Detailed description of the pull request / Additional comments

Changes to telemetry:

  • Changed the name of the telemetry related classes from Logger to Telemetry. (I didn't ask if I should, so feel free to ask to rename or revert)
  • Changed a couple of uses of the telemetry logger to use the file logger. We won't see these in ETW anymore, but we'll now get them with all the other logs.
  • Added a file logger for the whole app that is used during initialization, and in settings. Dashboard and SetupTool still have their own log files.
  • Changed the telemetry logger to only take events deriving from EventBase. This ensures that we always add privacy tags to our events and so they don't get filtered out. Also added a function to replace sensitive strings from an event's data so we always remember to remove PII
  • Added telemetry events for the results of applying configuration files

Validation steps performed

Manually verified telemetry events produced with TRTT

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@florelis
Copy link
Member Author

florelis commented May 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis
Copy link
Member Author

florelis commented May 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@EricJohnson327
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

# Conflicts:
#	settings/DevHome.Settings/Views/AccountsPage.xaml.cs
@florelis
Copy link
Member Author

florelis commented May 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@florelis florelis merged commit 3b498e2 into microsoft:main May 1, 2023
11 checks passed
@florelis florelis deleted the configurationEvents branch May 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants