Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to DevHome #113

Merged
merged 3 commits into from Mar 28, 2023
Merged

Add logging to DevHome #113

merged 3 commits into from Mar 28, 2023

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Mar 27, 2023

Summary of the pull request

Copy the DevHome.Logging project from the GitServices repo. Eventually this will go into SDK to be used by both places, but just use exact copy for now. Add logging to Dashboard.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau
Copy link
Contributor Author

krschau commented Mar 27, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@vineeththomasalex vineeththomasalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as this worked locally, and is a copy of the same project in Plugin repo, we should be good.

@krschau
Copy link
Contributor Author

krschau commented Mar 28, 2023

Additional related work to be done in #117

@krschau krschau merged commit 7907138 into main Mar 28, 2023
11 checks passed
@krschau krschau deleted the user/krschau/logging branch March 28, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants