Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter shown widgets to those from packages that also implement the Dev Home extension #1605

Merged
merged 4 commits into from Sep 29, 2023

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Sep 27, 2023

Summary of the pull request

We want to open up the widgets we show as available to the user, but we still want to limit the widgets to ones specifically meant to be shown in Dev Home. So instead of filtering on widget provider name, instead we will show widgets that also implement the Dev Home extension.

We do this by finding all installed packages that implement com.microsoft.windows.widgets' in the same way we find those that implement com.microsoft.devhome`. In order to do this, we need to add com.microsoft.windows.widgets as a AppExtensionHost in the appxmanifest. Then we can take the intersection of the two lists, and a list of the PackageFamilyNames of that intersection.

We use the PackageFamilyName since that will match the first part of the Widget Provider's Id, so we can compare that Id to the list and know that the widget came from a package we want to include.

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

src/Services/ExtensionService.cs Show resolved Hide resolved
src/Services/ExtensionService.cs Outdated Show resolved Hide resolved
tools/Dashboard/DevHome.Dashboard/Helpers/WidgetHelpers.cs Outdated Show resolved Hide resolved
@krschau krschau merged commit 89f625d into main Sep 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom widgets require a Microsoft package ID
3 participants