This repository was archived by the owner on Jun 5, 2025. It is now read-only.
Dev Home no longer registers for the DeveloperId provider#1834
Merged
EricJohnson327 merged 2 commits intomainfrom Feb 1, 2024
Merged
Dev Home no longer registers for the DeveloperId provider#1834EricJohnson327 merged 2 commits intomainfrom
EricJohnson327 merged 2 commits intomainfrom
Conversation
EricJohnson327
requested review from
dhoehna,
dkbennett,
krschau,
ssparach and
vineeththomasalex
dkbennett
suggested changes
Nov 7, 2023
Member
dkbennett
left a comment
dkbennett
left a comment
There was a problem hiding this comment.
Kristen is correct, the extension definition is needed for Core Widgets. The Guid specified is the same as the core widget extension.
Recommend changing this to just remove the DeveloperIdProvider and leave the rest of the extension as-is.
krschau
approved these changes
Nov 21, 2023
vineeththomasalex
approved these changes
Nov 30, 2023
dkbennett
approved these changes
Jan 10, 2024
EricJohnson327
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the pull request
Dev Home was registering DeveloperIDProvider, but never actually created one. This was leftover code from when core widgets were initially created.
References and relevant issues
Detailed description of the pull request / Additional comments
Validation steps performed
PR checklist