Handle race conditions during parallel instance inserts in the same study #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsugarman
reviewed
Apr 9, 2022
src/Microsoft.Health.Dicom.SqlServer/Features/Schema/Sql/Sprocs/AddInstanceV6.sql
Show resolved
Hide resolved
test/Microsoft.Health.Dicom.Tests.Integration/Persistence/IndexDataStoreTests.cs
Show resolved
Hide resolved
wsugarman
approved these changes
Apr 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We are holding a UPDLOCK on study which still allows inserts. Parallel new instance inserts in a study can result in dupe key on studyInstanceUID. Holding a SERIALIZATION lock is correct but results in slow instance inserts and deadLocks on rangelock.
Related issues
AB#90184
Testing
Added new integration test.
Manually tests