Retrieve original file properties when requested #3360
Conversation
src/Microsoft.Health.Dicom.Core/Features/Retrieve/RetrieveResourceService.cs
Outdated
Show resolved
Hide resolved
| @@ -383,6 +386,27 @@ private async Task<InstanceMetadata> GetInstanceMetadata(InstanceIdentifier inst | |||
| instanceIdentifier.StudyInstanceUid, | |||
| instanceIdentifier.SeriesInstanceUid, | |||
| instanceIdentifier.SopInstanceUid, | |||
| isOriginalVersion: true, | |||
There was a problem hiding this comment.
is this correct? that is it always true?
There was a problem hiding this comment.
is there any way we can make this safer based on what feature supports requesting original vs not?
There was a problem hiding this comment.
For frames, we always get from original even after update. only time we do get the latest is when they need transcoding.
There was a problem hiding this comment.
I still think we should do something here to make the contract clearer vs passing these booleans around. We've run into easy bugs in the past with this - today it's very clear that only in some very specific instances do we even allow for either or, and in some we only allow original, and in some we only allow latest. We should find away to centrally describe this contract
There was a problem hiding this comment.
Updated the variable to initialversion, which can be either original or latest depends on update happened or not
test/Microsoft.Health.Dicom.Tests.Integration/Persistence/InstanceStoreTests.cs
Show resolved
Hide resolved
Description
Retrieve original file properties when requested
Related issues
Addresses AB#115194
Testing
Added new integration tests