Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify required WinSDK version #389

Closed
Pospelove opened this issue Jun 1, 2023 · 2 comments · Fixed by #390
Closed

Clarify required WinSDK version #389

Pospelove opened this issue Jun 1, 2023 · 2 comments · Fixed by #390
Assignees

Comments

@Pospelove
Copy link

readme says: "Use of the Windows 10 May 2020 Update SDK (19041) or later is required for Visual Studio"

but users are not able to install directxtk via vcpkg before updating to the latest version available (see microsoft/vcpkg#31737)
profile
P.S. maybe worth including winsdk ver check into the portfile itself

@kkEngine
Copy link

kkEngine commented Jun 1, 2023

When trying to build via vcpkg on Win 10 sdk (10.0.20348.0), errors occured only in the file "C:\Program Files (x86)\Windows Kits\10\include\10.0.20348.0\winrt\wrl\event.h"

@walbourn
Copy link
Member

walbourn commented Jun 1, 2023

The failure here is due to the combination of using the "19.36.32532.0" (i.e. Visual Studio 2022 17.6) compiler with the older Windows SDK. In recent versions of DirectX Tool Kit, I enabled some additional conformance switches when using the new complier. It appears that /Zc:templateScope is not compatible with older Windows SDKs. I'll look at updating the CMakeLists to not use that switch with SDKs prior to 22000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants