Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Use https URL for accessing NPM registry data #174

Merged
merged 2 commits into from
Dec 25, 2021

Conversation

domdomegg
Copy link
Contributor

Currently dts-gen is broken as it attempts to access the registry by http, which results in a 301 to https. This fixes that error by using https in the first place.

Currently dts-gen is broken as it attempts to access the registry by http, which results in a 301 to https. This fixes that error by using https in the first place.
@domdomegg
Copy link
Contributor Author

Related: #172 attempts to fix this by following the 301. Both of these could be merged so we don't have an unnecessary redirect in the first place and to provide future robustness.

Copy link

@pimterry pimterry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just about to open a PR to do exactly the same thing 👍

@orta
Copy link
Contributor

orta commented Dec 25, 2021

Agree, thanks folks

@orta orta merged commit e339e55 into microsoft:master Dec 25, 2021
@Methuselah96
Copy link

@orta Is there a plan to release a new version with the fix?

@domdomegg
Copy link
Contributor Author

@RyanCavanaugh are you able to cut a new release of dts-gen to fix this?

@Soldy
Copy link

Soldy commented Jul 19, 2022

10 months old Bugs...
Still there...
The fix is there:
e339e55
No one merge.
Thank u Microsoft.
I am lost without you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants