Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ebpfclient : API surface for prog load, attach, maps, pinning, query #81

Closed
poornagmsft opened this issue Apr 25, 2021 · 3 comments · Fixed by #290 or #368
Closed

ebpfclient : API surface for prog load, attach, maps, pinning, query #81

poornagmsft opened this issue Apr 25, 2021 · 3 comments · Fixed by #290 or #368
Assignees
@saxena-anurag
Labels
ebpfumapi PR/Issues for ebpf UM API triaged Discussed in a triage meeting
Milestone
2108

Comments

@poornagmsft
Copy link
Contributor

@saxena-anurag
@poornagmsft poornagmsft added the ebpfumapi PR/Issues for ebpf UM API label Apr 25, 2021
@poornagmsft poornagmsft added this to the 2106 milestone Apr 25, 2021
@dthaler dthaler mentioned this issue May 5, 2021
Closed
This was referenced May 29, 2021
Closed
Closed
@dthaler dthaler added the triaged Discussed in a triage meeting label Jun 7, 2021
@saxena-anurag saxena-anurag mentioned this issue Jun 19, 2021
Merged
@dthaler dthaler reopened this Jun 25, 2021
@dthaler
Copy link
Collaborator

dthaler commented Jun 25, 2021

Still missing APIs for:

@saxena-anurag
Copy link
Contributor

Actually many more APIs are remaining as per the API doc.

@dthaler dthaler modified the milestones: 2106, 2107 Jul 7, 2021
@poornagmsft poornagmsft modified the milestones: 2107, Backlog Jul 26, 2021
@dthaler dthaler modified the milestones: Backlog, 2108 Jul 27, 2021
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
0ea4d18 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler dthaler mentioned this issue Jul 28, 2021
Merged
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
ca1b5f7 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
7eabe4f 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
9666033 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
5c0645a 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
1c44da5 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler referenced this issue in dthaler/ebpf-for-windows Jul 28, 2021
@dthaler
Libbpf API compatibility
ef7e297 
Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
dthaler added a commit that referenced this issue Jul 30, 2021
@dthaler
Libbpf API compatibility (#350)
8006f18 
* Libbpf API compatibility

Libbpf is incorporated as a submodule just for the header file.
As discussed in issue #84, we cannot currently use the implementation
since it is very Linux and GCC specific.

This PR also fixes a bug where the user-mode API was calling
CloseHandle directly instead of Platform::CloseHandle which is needed
to make tests work with the mock platform.

Addresses #84

Some code will be cleaner once issue #81 is done

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler dthaler linked a pull request Aug 10, 2021 that will close this issue
Add eBPF UM APIs #368
Merged
@dthaler dthaler reopened this Aug 11, 2021
@dthaler
Copy link
Collaborator

dthaler commented Aug 11, 2021

The main items were done, moving the remaining items to a separate (smaller in scope) issue to track

@dthaler dthaler closed this as completed Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saxena-anurag saxena-anurag

Labels
ebpfumapi PR/Issues for ebpf UM API triaged Discussed in a triage meeting
Projects
None yet
Milestone
2108
3 participants
@dthaler @saxena-anurag @poornagmsft