Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise STATUS_ASSERTION_FAILURE on test timeout #2272

Merged
merged 3 commits into from
Apr 7, 2023

Conversation

Alan-Jowett
Copy link
Member

Part 1 of #2269

Description

Add code to fire a watchdog timer if an individual test takes longer than 300 seconds.

Testing

CI/CD

Documentation

No.

@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #2272 (225892b) into main (9295c67) will decrease coverage by 0.10%.
The diff coverage is 92.06%.

@@            Coverage Diff             @@
##             main    #2272      +/-   ##
==========================================
- Coverage   83.60%   83.50%   -0.10%     
==========================================
  Files         151      153       +2     
  Lines       28276    28331      +55     
==========================================
+ Hits        23641    23659      +18     
- Misses       4635     4672      +37     
Impacted Files Coverage Δ
tests/libs/common/ebpf_watchdog_timer.h 83.33% <83.33%> (ø)
tests/api_test/api_test.cpp 97.55% <100.00%> (+<0.01%) ⬆️
tests/bpf2c_tests/raw_bpf.cpp 96.14% <100.00%> (+0.01%) ⬆️
tests/end_to_end/end_to_end.cpp 97.71% <100.00%> (+<0.01%) ⬆️
tests/libs/common/watchdog.h 100.00% <100.00%> (ø)
tests/netebpfext_unit/netebpfext_unit.cpp 99.54% <100.00%> (+<0.01%) ⬆️
tests/sample/ext/app/sample_ext_app.cpp 98.61% <100.00%> (+0.01%) ⬆️
tests/socket/socket_tests.cpp 98.85% <100.00%> (+<0.01%) ⬆️
tests/unit/wer_report_test_wrapper.cpp 99.30% <100.00%> (+0.10%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Alan-Jowett Alan-Jowett marked this pull request as draft April 4, 2023 17:05
@Alan-Jowett
Copy link
Member Author

Converting to draft until we can determine the root cause of the failures.

Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@Alan-Jowett Alan-Jowett marked this pull request as ready for review April 5, 2023 16:09
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
Signed-off-by: Alan Jowett <alanjo@microsoft.com>
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Apr 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2023
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Apr 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 6, 2023
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Apr 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 6, 2023
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Apr 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 6, 2023
@saxena-anurag saxena-anurag added this pull request to the merge queue Apr 6, 2023
Merged via the queue into microsoft:main with commit e8f437f Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants