Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change cleanup logic in ebpf_tracing.cmd #2412

Merged
merged 23 commits into from
May 2, 2023
Merged

Change cleanup logic in ebpf_tracing.cmd #2412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a51fc18
revised
gtrevi Apr 28, 2023
578a3a6
Add deletion
gtrevi Apr 28, 2023
6ef6be5
Merge branch 'microsoft:main' into gtrevi/trace-script-update
gtrevi Apr 28, 2023
b507642
wip
gtrevi Apr 28, 2023
e327144
wip
gtrevi Apr 28, 2023
678b845
wip
gtrevi Apr 28, 2023
8acbbd7
Added named parameters to script, parametrazed tasks.
gtrevi Apr 28, 2023
40417c5
nit
gtrevi Apr 28, 2023
1a27cff
cleanup
gtrevi Apr 28, 2023
9337687
cleanup
gtrevi Apr 28, 2023
f46b762
Optimizations and cleanup
gtrevi Apr 28, 2023
1acd45c
msg
gtrevi Apr 28, 2023
b2e9836
offset periodic task from logman by 2'
gtrevi Apr 28, 2023
0c2506d
Merge branch 'microsoft:main' into gtrevi/trace-script-update
gtrevi Apr 29, 2023
227f9d8
Merge branch 'microsoft:main' into gtrevi/trace-script-update
gtrevi Apr 30, 2023
41244d9
Change cleanup logic
gtrevi Apr 30, 2023
dc69cb8
Final values
gtrevi Apr 30, 2023
b850594
nit
gtrevi Apr 30, 2023
453e713
comment
gtrevi Apr 30, 2023
d509b73
usage
gtrevi Apr 30, 2023
42c728e
Update committed folder size to 200mb.
gtrevi May 1, 2023
e0f1de4
Update defaults
gtrevi May 1, 2023
903f6a6
Merge branch 'microsoft:main' into gtrevi/trace-script-update
gtrevi May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 30 additions & 15 deletions scripts/ebpf_tracing.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ set "trace_path="
set "trace_name=ebpf_diag"
set "rundown_period=0:35:00"
set "max_file_size_mb=20"
set "max_committed_etl_files=30"
set "max_committed_folder_size_mb=200"
set "max_committed_wfp_state_files=1"

:parse_args
Expand All @@ -34,7 +34,7 @@ if "%~1" == "/trace_path" set "trace_path=%~2" & shift & shift & goto :parse_arg
if "%~1" == "/trace_name" set "trace_name=%~2" & shift & shift & goto :parse_args
if "%~1" == "/rundown_period" set rundown_period=%~2 & shift & shift & goto :parse_args
if "%~1" == "/max_file_size_mb" set max_file_size_mb=%~2 & shift & shift & goto :parse_args
if "%~1" == "/max_committed_etl_files" set max_committed_etl_files=%~2 & shift & shift & goto :parse_args
if "%~1" == "/max_committed_folder_size_mb" set max_committed_folder_size_mb=%~2 & shift & shift & goto :parse_args
if "%~1" == "/max_committed_wfp_state_files" set max_committed_wfp_state_files=%~2 & shift & shift & goto :parse_args
echo Unknown parameter: "%~1"
goto :usage
Expand Down Expand Up @@ -62,7 +62,7 @@ if "%trace_path%" == "" (
@rem echo trace_name=%trace_name%
@rem echo rundown_period=%rundown_period%
@rem echo max_file_size_mb=%max_file_size_mb%
@rem echo max_committed_etl_files=%max_committed_etl_files%
@rem echo max_committed_folder_size_mb=%max_committed_folder_size_mb%
@rem echo max_committed_wfp_state_files=%max_committed_wfp_state_files%

@rem Internal constants
Expand Down Expand Up @@ -118,12 +118,22 @@ if "%command%"=="periodic" (
move /y "!trace_path!\%%f" "!traceCommittedPath!" >nul
)

@rem Iterate over all the .ETL files in the 'traceCommittedPath' directory, and delete files overflowing `max_committed_etl_files`.
for /f "skip=%max_committed_etl_files% delims=" %%f in ('dir /b /o-d "!traceCommittedPath!\*.etl"') do ( del "!traceCommittedPath!\%%f" )

@rem Iterate over all the WFP-state files in the 'traceCommittedPath' directory, and delete files overflowing `max_committed_wfp_state_files`.
for /f "skip=%max_committed_wfp_state_files% delims=" %%f in ('dir /b /o-d "!traceCommittedPath!\wfpstate*.cab"') do ( del "!traceCommittedPath!\%%f" )

@rem Iterate over all the .ETL files in the 'traceCommittedPath' directory, and delete the older files overflowing `max_committed_folder_size_mb`.
set size=0
set /a max_committed_folder_size_kb=!max_committed_folder_size_mb! * 1024
for /f "skip=1 delims=" %%f in ('dir /b /o-d "!traceCommittedPath!\*.etl"') do (
for /f "skip=1 tokens=2 delims==; " %%g in ('wmic datafile where "name='!traceCommittedPath:\=\\!\\%%f'" get filesize /value') do (
set "file_size=%%g"
set /a size=!size! + !file_size! / 1024
if !size! gtr !max_committed_folder_size_kb! (
del "!traceCommittedPath!\%%f"
)
)
)

) else if "%command%"=="start" (

@rem Set up the tracing session.
Expand Down Expand Up @@ -156,17 +166,22 @@ endlocal
exit /b 0

:usage
echo Usage: ebpf_tracing.cmd command /trace_path path [/trace_name name] [/rundown_period ^<period as (H:mm:ss)^>] [/max_file_size_mb size] [/max_committed_etl_files count] [/max_committed_wfp_state_files count]
echo command (mandatory) Valid values are: [start, stop, periodic]
echo /trace_path path (mandatory) Path into which the tracing will be located (creates it if it does not exist).
echo /trace_name name Name of the logman trace (Default: "ebpf_diag")
echo /rundown_period period Period, expressed as (H:mm:ss) for saving and generating a new ETL log, and for generating a WFP state snapshot (Default: 0:35:00).
echo /max_file_size_mb size Maximum size set for an ETL log (Default: 20).
echo /max_committed_etl_files count Number of (most recent) .ETL files to keep in the main 'trace_path\committed' (Default: 30)
echo /max_committed_wfp_state_files count Number of (most recent) WFP-state .CAB files to keep in the main 'trace_path\committed' (Default: 1).
echo Usage: ebpf_tracing.cmd command /trace_path path [/trace_name name] [/rundown_period period] [/max_file_size_mb size] [/max_committed_folder_size_mb count] [/max_committed_wfp_state_files count]
echo:
echo Valid parameters:
echo:
echo <command> - (mandatory) Valid values are: [start, stop, periodic]
echo /trace_path path - (mandatory) Path into which the tracing will be located (creates it if it does not exist).
echo /trace_name name - Name of the logman trace (Default: "ebpf_diag")
echo /rundown_period period - Period, expressed as (H:mm:ss), for saving and generating a new ETL log, and for generating a WFP state snapshot (Default: 0:35:00).
echo /max_file_size_mb size - Maximum size set for an ETL log (Default: 20).
echo /max_committed_folder_size_mb count - Maximum overall size for (most recent) .ETL files to keep in the main 'trace_path\committed' (Default: 200)
echo /max_committed_wfp_state_files count - Number of (most recent) WFP-state .CAB files to keep in the main 'trace_path\committed' (Default: 1).
echo:
echo Examples (overriding defaults):
echo:
echo ebpf_tracing.cmd start /trace_name ebpf_diag /trace_path "%SystemRoot%\Logs\eBPF" /rundown_period 0:35:00 /max_file_size_mb 20
echo ebpf_tracing.cmd stop /trace_name ebpf_diag /trace_path "%SystemRoot%\Logs\eBPF"
echo ebpf_tracing.cmd periodic /trace_path "%SystemRoot%\Logs\eBPF" /max_file_size_mb 20 /max_committed_etl_files 30 /max_committed_wfp_state_files 1
echo ebpf_tracing.cmd periodic /trace_path "%SystemRoot%\Logs\eBPF" /max_file_size_mb 20 /max_committed_folder_size_mb 30 /max_committed_wfp_state_files 1
endlocal
exit /b 1
Binary file modified scripts/ebpf_tracing_periodic_task.xml
View file
Open in desktop
Binary file not shown.