Change cleanup logic in ebpf_tracing.cmd
#2412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2412 +/- ##
==========================================
+ Coverage 84.09% 84.18% +0.08%
==========================================
Files 154 154
Lines 28774 28774
==========================================
+ Hits 24197 24222 +25
+ Misses 4577 4552 -25 |
gtrevi
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft and
delaramamiri
as code owners
dthaler
approved these changes
May 1, 2023
matthewige
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
\committedfolder cleanup logic, to a more intuitive "overall size" evaluation.The logic now evaluates the overall size of the committed folder and cleans up older files overflowing what specified in the
max_committed_folder_size_mbparameter.The default value of
max_committed_folder_size_mbis set to 200, taking into account an overall target size of 30Mb for a full zip of the folder contents, with an average compression ratio of 8.5 of the original files in the folder.Testing
Local 12+h testing
Documentation
n.a.