Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up native NMR handle only if not null #2530

Merged
merged 1 commit into from
May 30, 2023

Conversation

mtfriesen
Copy link
Collaborator

@mtfriesen mtfriesen commented May 30, 2023

Description

Resolves #2529.

Testing

Tested locally using XDP stress test. I highly recommend that eBPF enable driver verifier with fault injection to catch these kinds of bugs. That's all XDP does to repro. I've filed a feature request to add this coverage to eBPF: #2531.

Documentation

N/A.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #2530 (737ebed) into main (b054f0f) will decrease coverage by 0.15%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #2530      +/-   ##
==========================================
- Coverage   84.18%   84.04%   -0.15%     
==========================================
  Files         157      157              
  Lines       29037    29038       +1     
==========================================
- Hits        24446    24404      -42     
- Misses       4591     4634      +43     
Impacted Files Coverage Δ
libs/execution_context/ebpf_native.c 90.94% <71.42%> (-0.10%) ⬇️

... and 13 files with indirect coverage changes

@saxena-anurag saxena-anurag added the bug Something isn't working label May 30, 2023
@saxena-anurag saxena-anurag added this pull request to the merge queue May 30, 2023
Merged via the queue into microsoft:main with commit 15c88bb May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NMR crash in ebpf_native_terminate
3 participants