-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CICD failure #2548
Merged
Merged
Fix CICD failure #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delaramamiri
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
shankarseal,
dv-msft and
gtrevi
as code owners
June 6, 2023 06:28
Codecov Report
@@ Coverage Diff @@
## main #2548 +/- ##
==========================================
- Coverage 83.99% 83.97% -0.03%
==========================================
Files 157 157
Lines 29116 29116
==========================================
- Hits 24456 24449 -7
- Misses 4660 4667 +7 |
dthaler
approved these changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge this to unblock other PRs even if this isn't the best solution for the problem.
Alan-Jowett
approved these changes
Jun 6, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 6, 2023
gtrevi
pushed a commit
that referenced
this pull request
Jun 7, 2023
Co-authored-by: Dhiren Vispute <86131363+dv-msft@users.noreply.github.com>
saxena-anurag
added a commit
that referenced
this pull request
Jun 19, 2023
* Fix build errors with Visual Studio 17.6.0 (#2483) * Fix build errors with Visual Studio 17.6.0 Signed-off-by: Dave Thaler <dthaler@microsoft.com> * PR feedback Signed-off-by: Dave Thaler <dthaler@microsoft.com> --------- Signed-off-by: Dave Thaler <dthaler@microsoft.com> * Cherry-pick #2499, #2483. * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <dthaler@microsoft.com> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <dthaler@microsoft.com> * Source update to v0.9.1 * Revert "Cherry-pick #2499, #2483." This reverts commit eab9bbe. * Capture bpftool output in diagnostic scripts (#2484) * tmp working commit * working script * working E2E scripts * minor formatting * Tune ebpf_tracing.cmd to use the least amount of CPU. (#2499) * Remove wfp compression * Move the timestamp calculation. * wip * feedback * Update scripts/ebpf_tracing.cmd Co-authored-by: Dave Thaler <dthaler@microsoft.com> * Setting max_file_size_mb to the final max allowed. * maximize sizes --------- Co-authored-by: Dave Thaler <dthaler@microsoft.com> * Add rundown files compression as an option to `ebpf_tracing.cmd`. (#2537) * Add 'compress_rundown_state_files' option * nit * typo * fix CICD failure (#2548) Co-authored-by: Dhiren Vispute <86131363+dv-msft@users.noreply.github.com> * nit src refresh (whitespace) * Fix redirected_by_self check for dual stack sockets (#2562) * Cherry -picks from #2600 * fix typo --------- Signed-off-by: Dave Thaler <dthaler@microsoft.com> Co-authored-by: Dave Thaler <dthaler@microsoft.com> Co-authored-by: Matthew Ige <matthewige1@gmail.com> Co-authored-by: Delaram Amiri <108862804+delaramamiri@users.noreply.github.com> Co-authored-by: Dhiren Vispute <86131363+dv-msft@users.noreply.github.com> Co-authored-by: Anurag Saxena <43585259+saxena-anurag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2538
Scheduled run failed:
https://github.com/microsoft/ebpf-for-windows/actions/runs/5149210014/jobs/9271934842
Same for other PRs trying to build.
The "Create verifier project" fails with error:
CMake Error at CMakeLists.txt:4 (project):
The CMAKE_C_COMPILER:
is not a full path to an existing compiler tool.
https://github.com/actions/runner-images/blob/main/images/win/Windows2022-Readme.md says
Testing
CICD
Documentation
N/A