Change trace in ebpf_pinning_table_find

[shpalani]

Description

Problem:
ebpf_pinning_table_find() returns EBPF_RETURN_RESULT(retval), which prints success or failure trace upon return.

In _ebpf_native_reuse_map(), ebpf_pinning_table_find() was printing a trace with an error.
It is not an error if the Key is not found in the pinning table, as there will be no entry for the newly created map.

Solution:

• Added a new macro EBPF_RETURN_FUNCTION_RESULT log trace to log the result from the function, and return.
• The ebpf_core_get_pinned_object() caller will log and return EBPF_RETURN_FUNCTION_RESULT .
• The callers will print the error trace:
  1. _ebpf_native_reuse_map()
  2. _ebpf_core_protocol_get_pinned_object()

Testing

_Do any existing tests cover this change? Are new tests needed? No

Before fix
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_native_load_programs
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]_ebpf_native_create_maps
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]_ebpf_native_initialize_maps
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]_ebpf_native_initialize_maps returned success
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_core_get_pinned_object
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_pinning_table_find
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_pinning_table_find returned error,19
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_core_get_pinned_object returned error,19
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_core_create_map
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_map_create
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]eBPF object initialized,0xFFFFC60C2A4E4F30,1
[38]1EB8.11F8::‎2023‎-‎10‎-‎06 16:21:56.698 [EbpfForWindowsProvider]ebpf_map_create returned success

xdp_trace_withoutfix.txt

After fix:

[1]2114.0F94::2023/11/08-12:58:11.849601200 [EbpfForWindowsProvider]{"Entry":"_ebpf_native_reuse_map","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496012Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"opcode":1,"keywords":"0x1"}}
[1]2114.0F94::2023/11/08-12:58:11.849602500 [EbpfForWindowsProvider]{"Entry":"ebpf_core_get_pinned_object","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496025Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"opcode":1,"keywords":"0x1"}}
[1]2114.0F94::2023/11/08-12:58:11.849603100 [EbpfForWindowsProvider]{"Entry":"ebpf_pinning_table_find","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496031Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"opcode":1,"keywords":"0x1"}}
[1]2114.0F94::2023/11/08-12:58:11.849610600 [EbpfForWindowsProvider]{"Message":"ebpf_pinning_table_find returned result","Result":19,"meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496106Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"keywords":"0x2"}}
[1]2114.0F94::2023/11/08-12:58:11.849616100 [EbpfForWindowsProvider]{"Message":"ebpf_core_get_pinned_object returned result","Result":19,"meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496161Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"keywords":"0x2"}}
[1]2114.0F94::2023/11/08-12:58:11.849616800 [EbpfForWindowsProvider]{"Message":"_ebpf_native_reuse_map returned success","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfSuccess","time":"2023-11-08T20:58:11.8496168Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"keywords":"0x2"}}
[1]2114.0F94::2023/11/08-12:58:11.849624400 [EbpfForWindowsProvider]{"Entry":"ebpf_core_create_map","meta":{"provider":"EbpfForWindowsProvider","event":"EbpfGenericMessage","time":"2023-11-08T20:58:11.8496244Z","cpu":1,"pid":8468,"tid":3988,"channel":11,"level":5,"opcode":1,"keywords":"0x1"}}
[1]2114.0F94::2023/11/08-12:58:11.849625000 [EbpfForWindowsProvider]

xdp_trace.txt

Documentation

_Is there any documentation impact for this change?No

Installation

_Is there any installer impact for this change? No

Updated