Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from epoch_flush to epoch_synchronize #3039

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

Alan-Jowett
Copy link
Member

Description

New API, ebpf_epoch_synchronize, that blocks until the current epoch ends.
Add synchronize to start of perf run to minimize noise.

Testing

CI/CD

Documentation

No.

Installation

No.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #3039 (0eca009) into main (84921c2) will decrease coverage by 7.37%.
Report is 2 commits behind head on main.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   83.98%   76.62%   -7.37%     
==========================================
  Files         141      131      -10     
  Lines       26544    22774    -3770     
==========================================
- Hits        22294    17450    -4844     
- Misses       4250     5324    +1074     
Files Coverage Δ
libs/execution_context/ebpf_core.c 89.48% <100.00%> (+0.82%) ⬆️
libs/execution_context/ebpf_program.c 71.69% <100.00%> (-10.06%) ⬇️
libs/runtime/ebpf_epoch.c 93.11% <100.00%> (+3.59%) ⬆️
tests/end_to_end/netsh_test.cpp 99.50% <100.00%> (+0.71%) ⬆️
libs/runtime/unit/platform_unit_test.cpp 96.66% <50.00%> (-2.29%) ⬇️

... and 85 files with indirect coverage changes

saxena-anurag
saxena-anurag previously approved these changes Nov 16, 2023
matthewige
matthewige previously approved these changes Nov 16, 2023
libs/runtime/ebpf_epoch.h Outdated Show resolved Hide resolved
@Alan-Jowett Alan-Jowett marked this pull request as draft November 27, 2023 17:00
auto-merge was automatically disabled November 27, 2023 17:00

Pull request was converted to draft

Alan Jowett added 4 commits December 1, 2023 11:45
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
@Alan-Jowett Alan-Jowett marked this pull request as ready for review December 1, 2023 19:49
@Alan-Jowett Alan-Jowett added this pull request to the merge queue Jan 4, 2024
@Alan-Jowett Alan-Jowett removed this pull request from the merge queue due to a manual request Jan 4, 2024
@dv-msft dv-msft added this pull request to the merge queue Jan 4, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 4, 2024
@dv-msft dv-msft added this pull request to the merge queue Jan 4, 2024
Merged via the queue into microsoft:main with commit 4e69b3b Jan 4, 2024
76 checks passed
@Alan-Jowett Alan-Jowett deleted the epoch_synch branch January 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants