-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from epoch_flush to epoch_synchronize #3039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alan-Jowett
requested review from
dthaler,
poornagmsft,
saxena-anurag,
shankarseal,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
November 9, 2023 19:16
Codecov Report
@@ Coverage Diff @@
## main #3039 +/- ##
==========================================
- Coverage 83.98% 76.62% -7.37%
==========================================
Files 141 131 -10
Lines 26544 22774 -3770
==========================================
- Hits 22294 17450 -4844
- Misses 4250 5324 +1074
|
Alan-Jowett
force-pushed
the
epoch_synch
branch
from
November 16, 2023 16:27
0eca009
to
29de50f
Compare
saxena-anurag
previously approved these changes
Nov 16, 2023
matthewige
previously approved these changes
Nov 16, 2023
Alan-Jowett
dismissed stale reviews from matthewige and saxena-anurag
via
November 16, 2023 19:58
9e9b1fb
dthaler
reviewed
Nov 27, 2023
auto-merge was automatically disabled
November 27, 2023 17:00
Pull request was converted to draft
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Alan-Jowett
force-pushed
the
epoch_synch
branch
from
December 1, 2023 19:49
1b75b98
to
f6e5441
Compare
dthaler
approved these changes
Dec 5, 2023
dv-msft
approved these changes
Jan 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New API, ebpf_epoch_synchronize, that blocks until the current epoch ends.
Add synchronize to start of perf run to minimize noise.
Testing
CI/CD
Documentation
No.
Installation
No.