Reallocate packet #3344
Merged
Reallocate packet #3344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
Merged
shankarseal
force-pushed
the
reallocate_packet
branch
from
6dfdf75
to
8ed47b1
Compare
mtfriesen
previously approved these changes
Apr 1, 2024
gtrevi
previously approved these changes
Apr 2, 2024
dthaler
reviewed
Apr 2, 2024
shankarseal
force-pushed
the
reallocate_packet
branch
from
90ce48b
to
5ac466e
Compare
Alan-Jowett
previously approved these changes
Apr 3, 2024
matthewige
previously approved these changes
Apr 3, 2024
dthaler
previously approved these changes
Apr 3, 2024
shankarseal
dismissed stale reviews from dthaler, matthewige, and Alan-Jowett
via
022c2ef
shankarseal
force-pushed
the
reallocate_packet
branch
from
5ac466e
to
022c2ef
Compare
dthaler
previously approved these changes
Apr 3, 2024
shankarseal
force-pushed
the
reallocate_packet
branch
from
022c2ef
to
b88fcba
Compare
matthewige
approved these changes
Apr 4, 2024
Alan-Jowett
approved these changes
Apr 4, 2024
| // fixed. | ||
| if (program_info->program_type_specific_helper_prototype[index].flags.reallocate_packet != 0) { | ||
| hash_t::append_byte_range( | ||
| byte_range, program_info->program_type_specific_helper_prototype[index].flags); |
There was a problem hiding this comment.
is it possible to round each bit field to 8-bit boundary, and add the corresponding bytes to the hash? So for reallocate_packet, we can add 1 byte of data to the hash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note this PR must be completed after #3326 is merged.
This fixes #3090. A reallocate_packet flag is added to the helper function prototype metadata, to pass onto the PREVAIL verifier, to validate programs that uses any helper function that may change the packet pointers such as xdp_adjust_head.
Testing
A new netsh tests is added that tries to load an unsafe XDP program and fails.
Documentation
Updated extension documentation.
Installation
No changes to installation.