extension_header #3326
Merged
extension_header #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
force-pushed
the
fix_3277
branch
2 times, most recently
from
308e9c5
to
25505f5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3326 +/- ##
==========================================
+ Coverage 83.78% 84.48% +0.70%
==========================================
Files 143 147 +4
Lines 27297 27381 +84
==========================================
+ Hits 22870 23134 +264
+ Misses 4427 4247 -180 ☔ View full report in Codecov by Sentry. |
shankarseal
force-pushed
the
fix_3277
branch
4 times, most recently
from
6343916
to
dbac4a9
Compare
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
Alan-Jowett
previously approved these changes
Mar 8, 2024
dthaler
reviewed
Mar 8, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
dthaler
previously approved these changes
Mar 9, 2024
Merged
dthaler
previously approved these changes
Mar 10, 2024
dthaler
previously approved these changes
Mar 27, 2024
saxena-anurag
previously approved these changes
Mar 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
saxena-anurag
approved these changes
Mar 30, 2024
Alan-Jowett
approved these changes
Mar 30, 2024
shankarseal
added a commit
to shankarseal/ebpf-for-windows
that referenced
this pull request
Apr 1, 2024
* extension_header * fix logic error. * Re-purposing the size field to act as the "minor version". Additional validation checks are added. * PR Feedback. * fix break due to bad merge with PR microsoft#3372
This was referenced Apr 1, 2024
matthewige
pushed a commit
that referenced
this pull request
Apr 1, 2024
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #3277. The extension data structures now have version and size fields that can be used to check compatibility with extensions. This will be a breaking change for all extensions. The eBPF API for exporting program data has been renamed as well.
Testing
CI tasks. Later #2747 will be added as well.
Documentation
eBPFExtension.mdis modified.Installation
N/A.