Various fixes to the extension version logic. #3432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankarseal
changed the title
Merged
shankarseal
force-pushed
the
extension_struct_version
branch
2 times, most recently
from
f6af801
to
552bb47
Compare
shankarseal
requested review from
dthaler,
poornagmsft,
Alan-Jowett,
saxena-anurag,
dv-msft,
gtrevi,
shpalani,
matthewige,
mtfriesen and
rectified95
as code owners
dthaler
reviewed
Apr 16, 2024
gtrevi
reviewed
Apr 18, 2024
fix one more leak.
s# Please enter the commit message for your changes. Lines starting
shankarseal
force-pushed
the
extension_struct_version
branch
from
1f68ad0
to
fb44f9c
Compare
gtrevi
approved these changes
Apr 19, 2024
saxena-anurag
approved these changes
Apr 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR patches some more gaps in #3326 that was found by the regression tests introduced by #3421. Specifically, the previous PR did not take into account the array of
ebpf_helper_function_prototype_tinebpf_program_info_t. Processing program information from an older extension can cause crashes if the size of the individual array elements are not considered. The solution was to "normalize" inputebpf_program_datato the latest version with safe defaults before processing them.Testing
CI/CD with kernel mode regression tests.
Documentation
No documentation impact.
Installation
No installer impact._