Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow run failing due to missing pc-sub-key secret key in notebooks #173

Closed
rafaspadilha opened this issue Jun 6, 2024 · 1 comment
Closed

Workflow run failing due to missing pc-sub-key secret key in notebooks #173

rafaspadilha opened this issue Jun 6, 2024 · 1 comment
Assignees
@rafaspadilha
Labels
bug Something isn't working documentation Improvements or additions to documentation known issues Issues acknowledged by the team but still pending local cluster Issues encountered in local cluster next-release-fix Issues with a fix planned for the next release notebooks Issues encountered while running the notebooks workflows Issues encountered when running workflows

Comments

@rafaspadilha
Copy link
Contributor

In which step did you encounter the bug?

Notebook execution

Are you using a local or a remote (AKS) FarmVibes.AI cluster?

Local cluster

Bug description

When instantiating workflow runs in a few of the notebooks, we explicitly assign the pc_key parameter to fetch the Planetary Computer key from the cluster's key vault (with @SECRET(eywa-secrets, pc-sub-key)). This is causing the workflow run to fail if the secret pc-sub-key is not defined.

This happens in the forest_change_detection notebook:

image

Steps to reproduce the problem

Run the forest change detection notebook.
@rafaspadilha rafaspadilha added the bug Something isn't working label Jun 6, 2024
@rafaspadilha rafaspadilha self-assigned this Jun 6, 2024
@rafaspadilha rafaspadilha added the known issues Issues acknowledged by the team but still pending label Jun 6, 2024
@github-actions github-actions bot added local cluster Issues encountered in local cluster notebooks Issues encountered while running the notebooks triage Issues still not triaged by team labels Jun 6, 2024
@rafaspadilha rafaspadilha added documentation Improvements or additions to documentation workflows Issues encountered when running workflows and removed triage Issues still not triaged by team labels Jun 6, 2024
@rafaspadilha
Copy link
Contributor Author

rafaspadilha commented Jun 6, 2024 •
edited
Loading

Additionally, it seems that the Planetary Computer Hub will be retired, as discussed in microsoft/PlanetaryComputer#347.

With that, the API key will not be necessary to fetch data anymore. This will require revisiting FarmVibes.AI ops, workflows, and documentation.

A workaround for running the notebook is defining an empty string ("pc_key": "") as the value for this parameter.

@rafaspadilha rafaspadilha added the next-release-fix Issues with a fix planned for the next release label Jun 13, 2024
@rafaspadilha rafaspadilha mentioned this issue Jul 31, 2024
Merged
robertomest pushed a commit that referenced this issue Aug 1, 2024
@rafaspadilha @robertomest
Removing @Secrets(..., pc-sub-key) from notebooks (#187)
8be7698 
Fix for #173.

Planetary Computer does not uses API key anymore. Some of our notebooks are failing because of that (and because the secret has not been added to the cluster).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaspadilha rafaspadilha

Labels
bug Something isn't working documentation Improvements or additions to documentation known issues Issues acknowledged by the team but still pending local cluster Issues encountered in local cluster next-release-fix Issues with a fix planned for the next release notebooks Issues encountered while running the notebooks workflows Issues encountered when running workflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rafaspadilha