Updated the specification around adding foundation components #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
π Description
This update to the specification clarifies adding a "foundation" component with a specific
add-foundation-component
command.π©βπ» Reviewer Notes
Read through and make sure this command makes sense given the
add-component
command. Since theadd-component
command deals with adding via templates, theadd-foundation-component
is intended to explicit to adding foundation based component. This distinction was thought to be necessary as this adds the@microsoft/fast-foundation
dependency and begins to use the preconfigured design tokens, so if you are not intending to use those systems, you would simply use theadd-component
command for your custom components.β Checklist
General
β Next Steps