Add foundation components option #31
Assignees
Milestone
Comments
janechu
added a commit
that referenced
this issue
May 6, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This adds the `add-component` command. It uses a blank template and therefore will not pass the build until #35 is merged. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Closes #30 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> This is a rather long one. I would take a look first at #35 and see how the configurable blank template is setup before looking at this PR. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - #31
3 tasks
janechu
added a commit
that referenced
this issue
May 9, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This update to the specification clarifies adding a "foundation" component with a specific `add-foundation-component` command. ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> Read through and make sure this command makes sense given the `add-component` command. Since the `add-component` command deals with adding via templates, the `add-foundation-component` is intended to explicit to adding foundation based component. This distinction was thought to be necessary as this adds the `@microsoft/fast-foundation` dependency and begins to use the preconfigured design tokens, so if you are not intending to use those systems, you would simply use the `add-component` command for your custom components. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [ ] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - #31
3 tasks
janechu
added a commit
that referenced
this issue
May 10, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This update does the following: - Adds the `add-foundation-component` command - Adds the "blank" template to the list of foundation components - Updates the documentation to normalize it - Adds the documentation for the `add-foundation-component` command ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Partially takes care of #31 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> In order to not have a massive PR down the line, foundation components will be added individually as PRs. This PR only takes care of the command line option and moves the tests around to better facilitate this update. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Add each foundation component
3 tasks
janechu
added a commit
that referenced
this issue
May 12, 2022
…s, and patterns (#39) # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This work adds a private package to assist in revving the CLI and it includes the following work for use by the components: - Design tokens - Color utilities - Component style patterns It also speeds up the build by using the static generated storybook files to run on playwright. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> The files should be very similar to what was in `@microsoft/fast-components`, with a few fixes to integrate into the CLI. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Begin adding components
janechu
added a commit
that referenced
this issue
May 16, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change does the following: - Standardizes files used to be dot notation for example `fast.config.json` instead of `fastconfig.json`, this is more widely practiced and lets the other files needed be more obviously `fast.<command>.json` - Adds the Badge component - Enables dependencies to be added for each component with their versions ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Further work for #31 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> Note that as issues come up (needing dependencies, needing to install multiple components together in a future PR, this logic will be added). ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
This was referenced May 16, 2022
Merged
janechu
added a commit
that referenced
this issue
May 17, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the dialog foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
This was referenced May 17, 2022
janechu
added a commit
that referenced
this issue
May 17, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the foundation card component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 17, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the foundation disclosure component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 18, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the number-field foundation component. Also applied a small cleanup to some of the component testing. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
This was referenced May 18, 2022
Merged
janechu
added a commit
that referenced
this issue
May 19, 2022
<!--- Provide some background and a description of your work. --> Adds the number-field foundation component. Also applied a small cleanup to some of the component testing. <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Added the search foundation component. This change also specifies an entry point for typings in the adaptive UI package ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues with work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
<!--- Provide some background and a description of your work. --> Adds the number-field foundation component. Also applied a small cleanup to some of the component testing. <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
Adds the checkbox foundation component. Also moved some helper files for the component testing to a separate file and moved a component test to the components folder. <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
3 tasks
janechu
added a commit
that referenced
this issue
May 20, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the progress-ring foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continued work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Added the progress foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continued work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Added the foundation flipper component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 20, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the divider foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 23, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This work moves the individual playwright tests to their own files and leverages the setup from #53 so that temp files have their own uuid. Edit: This may seem like a lot of duplication, but I believe it is preferable to attempting to optimize too soon as we don't yet know what extra component-specific tests will be required. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## 👩💻 Reviewer Notes <!--- Provide some notes for reviewers to help them provide targeted feedback and testing. --> No changes, only file moves. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue work on #31
janechu
added a commit
that referenced
this issue
May 23, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the switch foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue work on #31
This was referenced May 23, 2022
Merged
janechu
added a commit
that referenced
this issue
May 24, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the toolbar foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 24, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Added the text-field foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
May 24, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> Adds the text-area foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding components
janechu
added a commit
that referenced
this issue
May 24, 2022
…foundation (#60) # Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> After doing some re-assessment of added foundation components it was found that a few were missing additional class logic, seemingly related to specific styling, and a few had extra elements baked into the definition. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Related to #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes.
janechu
added a commit
that referenced
this issue
May 25, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This adds the tooltip foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
janechu
added a commit
that referenced
this issue
Jun 1, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change adds the avatar foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continues work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue work on #31
janechu
added a commit
that referenced
this issue
Jun 2, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change adds the calendar foundation component. ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> Continued work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding components for #31
3 tasks
janechu
added a commit
that referenced
this issue
Jun 2, 2022
# Pull Request ## 📖 Description <!--- Provide some background and a description of your work. --> This change adds the following: - Ability to add required components in foundation components so that sub-components can be installed - Exports errors as functions so that arguments can be added to them for more precise error messaging - Added the accordion component - Added the accordion-item component ### 🎫 Issues <!--- List and link relevant issues here using the keyword "closes" if this PR will close an issue, eg. closes #411 --> - Continued work on #31 ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have added tests for my changes. - [x] I have tested my changes. - [x] I have updated the project documentation to reflect my changes. ## ⏭ Next Steps <!--- If there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next. --> - Continue adding foundation components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Add the option to specify a foundation component to the
add-componentcommand.Requirements
foundation/directory--foundationReliant on #29, #30
The text was updated successfully, but these errors were encountered: