-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added badge foundation component #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please no default exports π
packages/fast-cli/src/components/badge/template/component.definition.ts
Outdated
Show resolved
Hide resolved
packages/fast-cli/src/components/blank/template/component.definition.ts
Outdated
Show resolved
Hide resolved
a9f6135
to
f85c143
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the blank template, we might want to skip the definition as a separate module. I'm not sure. I think the pattern makes sense for the library components but I'm not sure if there would be value in doing that otherwise.
I was attempting to treat the blank template as a library component, just an empty one. I could update it in a subsequent PR to take a dependency on foundation. |
Pull Request
π Description
This change does the following:
fast.config.json
instead offastconfig.json
, this is more widely practiced and lets the other files needed be more obviouslyfast.<command>.json
π« Issues
Further work for #31
π©βπ» Reviewer Notes
Note that as issues come up (needing dependencies, needing to install multiple components together in a future PR, this logic will be added).
β Checklist
General
β Next Steps