Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added badge foundation component #42

Merged
merged 6 commits into from
May 16, 2022
Merged

Conversation

janechu
Copy link
Contributor

@janechu janechu commented May 13, 2022

Pull Request

πŸ“– Description

This change does the following:

  • Standardizes files used to be dot notation for example fast.config.json instead of fastconfig.json, this is more widely practiced and lets the other files needed be more obviously fast.<command>.json
  • Adds the Badge component
  • Enables dependencies to be added for each component with their versions

🎫 Issues

Further work for #31

πŸ‘©β€πŸ’» Reviewer Notes

Note that as issues come up (needing dependencies, needing to install multiple components together in a future PR, this logic will be added).

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

⏭ Next Steps

  • Continue adding foundation components

@EisenbergEffect EisenbergEffect self-requested a review May 16, 2022 20:31
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no default exports πŸ˜‰

@EisenbergEffect EisenbergEffect self-requested a review May 16, 2022 21:49
@janechu janechu force-pushed the users/janechu/add-badge-component branch from a9f6135 to f85c143 Compare May 16, 2022 21:51
Copy link
Contributor

@EisenbergEffect EisenbergEffect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the blank template, we might want to skip the definition as a separate module. I'm not sure. I think the pattern makes sense for the library components but I'm not sure if there would be value in doing that otherwise.

@janechu
Copy link
Contributor Author

janechu commented May 16, 2022

For the blank template, we might want to skip the definition as a separate module. I'm not sure. I think the pattern makes sense for the library components but I'm not sure if there would be value in doing that otherwise.

I was attempting to treat the blank template as a library component, just an empty one. I could update it in a subsequent PR to take a dependency on foundation.

@janechu janechu merged commit c46ddef into main May 16, 2022
@janechu janechu deleted the users/janechu/add-badge-component branch May 16, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants