Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the dialog component #44

Merged
merged 2 commits into from
May 17, 2022
Merged

Conversation

janechu
Copy link
Contributor

@janechu janechu commented May 16, 2022

Pull Request

πŸ“– Description

Adds the dialog foundation component.

🎫 Issues

Continues work on #31

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.

⏭ Next Steps

  • Continue adding foundation components

@EisenbergEffect
Copy link
Contributor

I just realized that the storybook stuff probably won't work because just importing the define module doesn't work until after we change over all the registration stuff. Until then, a design system has to be created and the registry function has to be called with its result passed to the design system. A bit ugly in this type of setup I'm going to imagine. Maybe next week I can rip all that out and we can switch this over...

@janechu
Copy link
Contributor Author

janechu commented May 17, 2022

I just realized that the storybook stuff probably won't work because just importing the define module doesn't work until after we change over all the registration stuff. Until then, a design system has to be created and the registry function has to be called with its result passed to the design system. A bit ugly in this type of setup I'm going to imagine. Maybe next week I can rip all that out and we can switch this over...

Oh, hmmm... I think some planning is in order after beta comes out. I'm fine with just slapping together a working situation for now and then we'll learn things when we attempt to migrate.

@janechu janechu merged commit c1fff6b into main May 17, 2022
@janechu janechu deleted the users/janechu/add-dialog-component branch May 17, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants