feat(fast-element): enable parent context references in repeat scenarios #3948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EisenbergEffect
requested review from
chrisdholt,
janechu and
nicholasrice
as code owners
nicholasrice
approved these changes
Sep 22, 2020
scomea
approved these changes
Sep 23, 2020
EisenbergEffect
deleted the
users/eisenbergeffect/repeat-grandparents
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
parentContextproperty to theExecutionContextwhich is now set by therepeatdirective's behavior when it sets up its own per-item context. This enables nested repeat templates to access up the repeat context and always get to any higher level repeat or the root view model regardless of the level of nesting.Closes #3848
Issue type checklist
Process & policy checklist